zip64: fix zip64 extended information issue #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pr0methean can we run the testts here? |
|
@Pr0methean any chance you can look at this one? |
Pr0methean
approved these changes
Jan 10, 2025
|
@Pr0methean anything we could do to move this along? |
|
Looking into the issue. Tests are failing to build on macOS, but it's not clear whether this PR is responsible. If it's not and anyone knows how to fix it, please do so in a separate PR. |
|
Looks like zstd-sys is linking against a zstd library that was built for a later macOS than the rest of I can take a look in a separate PR but it definitely doesn't seem related to this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A updated version of #248 and fix crypto case issue, now it can pass CI.
Fix zip64 extended information issue to fix zip file incorrect if size larger than 4GB.
According zip format 4.5.3:
The order of the fields in the zip64 extended
information record is fixed, but the fields MUST
only appear if the corresponding Local or Central
directory record field is set to 0xFFFF or 0xFFFFFFFF.